reduce allocations in GetExt#1045
Merged
Merged
Conversation
egibs
approved these changes
Jul 16, 2025
egibs
left a comment
egibs
left a comment
Member
There was a problem hiding this comment.
Nice! I wasn't a huge fan of my original implementation and this is much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce allocations in
GetExtThis change optimizes the
GetExtfunction by replacingstrings.Splitandfmt.Sprintfwith simpler index lookups and string slicing.This results in fewer heap allocations (
allocs/op) when scanning large sets of files and slightly better performance.Benchmark before:
Benchmark after: